Merged
Conversation
ohah
approved these changes
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the playground structure by consolidating duplicate code and reorganizing the file structure. The main objective is to merge PlaygroundGroups functionality into PlaygroundPage and extract the playground UI logic into a reusable PlaygroundWidget component.
- Extracted playground UI rendering logic into a new
PlaygroundWidgetcomponent in the widgets layer - Consolidated
PlaygroundGroupscomponent functionality intoPlaygroundPage - Created a unified
usePlaygroundStorethat manages both tabs and playground execution state - Reorganized the features/playground module structure with a dedicated model subdirectory
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/executeJS/src/widgets/playground/ui/playground-widget.tsx | New widget component extracted from playground-page, handles UI rendering for a single playground instance |
| apps/executeJS/src/widgets/playground/ui/index.ts | Export barrel for playground widget UI |
| apps/executeJS/src/widgets/playground/index.ts | Updated to export from ui subdirectory |
| apps/executeJS/src/pages/playground/playground-page.tsx | Refactored to incorporate PlaygroundGroups functionality and use new PlaygroundWidget |
| apps/executeJS/src/pages/playground/playground-groups.tsx | Deleted file (functionality merged into playground-page) |
| apps/executeJS/src/pages/playground/index.ts | Removed export of deleted PlaygroundGroups component |
| apps/executeJS/src/features/playground/model/store.ts | New unified store managing tabs and playground state |
| apps/executeJS/src/features/playground/model/store.test.ts | Comprehensive test suite for the playground store |
| apps/executeJS/src/features/playground/model/index.ts | Export barrel for model layer |
| apps/executeJS/src/features/playground/model/const.ts | Constants for playground feature |
| apps/executeJS/src/features/playground/index.ts | Updated to export from model subdirectory |
| apps/executeJS/src/app/index.tsx | Updated to use PlaygroundPage instead of PlaygroundGroups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ohah
pushed a commit
that referenced
this pull request
Dec 12, 2025
* refactor: 기존 playground-page 컴포넌트 제거 및 playground-groups > playground-page로 네이밍 변경 * feat: playground store 테스트 코드 추가 * refactor: feature/playground 폴더구조 수정 - model 폴더 생성 * refactor: widgets/playground 폴더구조 수정 - ui 폴더 생성
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 요약
📝 작업 내용
🔍 스크린샷
💡 참고 사항